Add more downstream hostcalls #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgryski
force-pushed
the
dgryski/http-downstream
branch
4 times, most recently
from
8ce4757 to
ff659ed
Compare
joeshaw
reviewed
Sep 8, 2025
|
I wonder if I should name the |
|
Maybe update this branch to use |
|
Yes, I'll update this to use the new code after your PR is merged. |
dgryski
force-pushed
the
dgryski/http-downstream
branch
from
e4e10f1 to
b62155f
Compare
|
Branch updated. Any thoughts on renaming |
cee-dub
reviewed
Sep 12, 2025
|
Added some comments back. |
cee-dub
reviewed
Sep 12, 2025
fsthttp/request.go
Outdated
Comment on lines
387
to
395
| fingerprint.DDOSDetected, err = req.abi.req.DownstreamDDOSDetected() | ||
| if err != nil { | ||
| return nil, fmt.Errorf("get ddos detected: %w", err) | ||
| } | ||
|
|
||
| fingerprint.FastlyKeyIsValid, err = req.abi.req.DownstreamFastlyKeyIsValid() | ||
| if err != nil { | ||
| return nil, fmt.Errorf("get fastly key is valid: %w", err) | ||
| } |
There was a problem hiding this comment.
I don't particularly like these two fields inside Fingerprint since they don't seem related.
Comment on lines
1055
to
1056
| // FastlyKeyIsValid is true if the request contains a valid Fastly API token. | ||
| FastlyKeyIsValid bool |
There was a problem hiding this comment.
Why do customers' apps need to know this?
|
PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.